Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 )
Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections ...................................................................... Patch Set 3: (1 comment) Were you able to test this in any way using iptables to drop packets? I'm particularly wondering whether our various network code paths handle ENOTCONN in a correct way (I'd assume they would just treat it as any other read error and disconnect, but would be good to try this once) http://gerrit.cloudera.org:8080/#/c/13702/3/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/13702/3/src/kudu/rpc/rpc-test.cc@798 PS3, Line 798: google::FlagSaver saver; no need for this -- our toplevel KuduTest base class handles this for all test cases automatically -- To view, visit http://gerrit.cloudera.org:8080/13702 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa1d66d83aea1cc82d07fc6217be5fc1306695bc Gerrit-Change-Number: 13702 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 21 Jun 2019 16:34:36 +0000 Gerrit-HasComments: Yes
