Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13702 )
Change subject: KUDU-2192: Enable TCP keepalive for all outbound connections ...................................................................... Patch Set 3: > Patch Set 3: > > The server shutdown test case in rpc-test is a good one but just wondering if > there are other similar types of test in the test suite which I can extend to > test this patch ? I think it's a bit difficult to test this one without iptables, right? If you kill -STOP a server would it stop responding to TCP keepalives? I would guess that the keepalive is handled at the kernel level and even if the process is kill -STOPed, the keepalives will keep getting handled. At one point I prototyped iptables integration into our minicluster but didn't quite finish that, and wouldn't block this patch. I think some manual testing is probably sufficient. Can you run your same Impala iptables test but with RPC TLS enabled? That path is different enough that I could see a problem happening there. -- To view, visit http://gerrit.cloudera.org:8080/13702 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa1d66d83aea1cc82d07fc6217be5fc1306695bc Gerrit-Change-Number: 13702 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 21 Jun 2019 17:37:23 +0000 Gerrit-HasComments: No
