Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 )
Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS2: It looks like the dimension label is only exposed in the locations code path for the purpose of the new Java test. Could we avoid doing that and have the test verify correctness some other way? Perhaps by looking at where the master placed the created table's replicas? -- To view, visit http://gerrit.cloudera.org:8080/13875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fc7797011df578000544147938bd15a6027f4c8 Gerrit-Change-Number: 13875 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 17 Jul 2019 16:22:12 +0000 Gerrit-HasComments: Yes
