Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 )
Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/13875/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java: http://gerrit.cloudera.org:8080/#/c/13875/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java@754 PS2, Line 754: the nit: a http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS2: > It looks like the dimension label is only exposed in the locations code pat +1 >From the other side, if making the cluster rebalancer tool to be aware of >dimension labels, what might be the best place to add this information? http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/catalog_manager.cc@4790 PS2, Line 4790: if (dimension) { : replica_pb->set_dimension_label(*dimension); : } remove: this is the piece of now deprecated structure http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/master.proto@375 PS2, Line 375: optional string dimension_label = 3; This structure/message has been deprecated a long time ago (v0.5.0), so I don't think anything that's related to a newly added features should touch this. Basically, no dimension label should be sent in response to those ancient clients. -- To view, visit http://gerrit.cloudera.org:8080/13875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fc7797011df578000544147938bd15a6027f4c8 Gerrit-Change-Number: 13875 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 17 Jul 2019 16:43:27 +0000 Gerrit-HasComments: Yes
