Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13875 )
Change subject: KUDU-2823 [java client] Support setting dimension for the newly created tablet ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS2: > +1 Thanks for your comments. :) I do this for two main reasons: 1. The cluster rebalancer tool needs to know the dimension label of tablet replica. 2. I don't think it's necessary to verify where the tablet replica are placed(It has been done in C++ API). In Java API, I think we just need to make sure the dimension label are set correctly. Emmm, maybe in this patch I should implement get dimension label of tablet replica in C++ too. http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/13875/2/src/kudu/master/master.proto@375 PS2, Line 375: optional string dimension_label = 3; > This structure/message has been deprecated a long time ago > (v0.5.0), so I don't think anything that's related to a newly added > features should touch this. Basically, no dimension label should > be sent in response to those ancient clients. This is because the InternedReplicaPB is converted into ReplicaPB in java client. https://github.com/apache/kudu/blob/99e94efeae33271910348a388531f58e460174a6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java#L2289 -- To view, visit http://gerrit.cloudera.org:8080/13875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fc7797011df578000544147938bd15a6027f4c8 Gerrit-Change-Number: 13875 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Thu, 18 Jul 2019 05:18:44 +0000 Gerrit-HasComments: Yes
