Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 )
Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 ...................................................................... Patch Set 3: (5 comments) Would be nice to see an end-to-end test that proves the expected padding/truncation semantics for the new types. http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/predicate-test.cc@1200 PS3, Line 1200: TEST_F(PredicateTest, TestCharPredicates) { Would it be possible to type-parameterize these new tests, perhaps along with TestStringPredicates and TestBinaryPredicates? http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: PS3: Do we want to doc that the char getter does _not_ pad with whitespace? http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/schema.h@84 PS3, Line 84: /// The length of a CHAR or VARCHAR column. "Maximum length". Should also doc whether we're talking about bytes or characters. http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/schema.h@398 PS3, Line 398: fixed length of a CHAR column In light of the fact that we truncate excess whitespace when writing and don't pad when reading, what does "fixed length" mean? http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/schema.cc@320 PS3, Line 320: if (data_->type.value() == KuduColumnSchema::DECIMAL) { Maybe convert this into a switch on data_->type.value()? -- To view, visit http://gerrit.cloudera.org:8080/13869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Gerrit-Change-Number: 13869 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 17 Jul 2019 17:21:39 +0000 Gerrit-HasComments: Yes
