Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 )
Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/predicate-test.cc@1200 PS3, Line 1200: TEST_F(PredicateTest, TestCharPredicates) { > Would it be possible to type-parameterize these new tests, perhaps along wi I'm not sure it would work here as most of this is the same, but there are differences based on types (AddColumn()->Type(), SetChar()/SetVarchar()/etc). I'm not too familiar with gtest, so I'm not sure if it's possible to do this with it, and if it is, is it worth it? In the very least (if I can get the type somehow), it would require two switches. http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: PS3: > Do we want to doc that the char getter does _not_ pad with whitespace? renamed these too to GetUnpaddedChar based on Grant's suggestion on the parent commit in partial row, it should make it clear. http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/schema.h@84 PS3, Line 84: /// The maximum length of a CHAR or VARCHAR column in characters. > "Maximum length". Should also doc whether we're talking about bytes or char Done http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/schema.h@398 PS3, Line 398: maximum length of a CHAR or a > In light of the fact that we truncate excess whitespace when writing and do nothing, didn't notice it wasn't changed here http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/schema.cc@320 PS3, Line 320: switch (data_->type.value()) { > Maybe convert this into a switch on data_->type.value()? Done -- To view, visit http://gerrit.cloudera.org:8080/13869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Gerrit-Change-Number: 13869 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2019 13:02:36 +0000 Gerrit-HasComments: Yes
