Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 )
Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 ...................................................................... Patch Set 5: (1 comment) Looks good but I'm still hoping you can add that end-to-end test I suggested in PS3. http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/13869/3/src/kudu/client/predicate-test.cc@1200 PS3, Line 1200: TEST_F(PredicateTest, TestCharPredicates) { > I'm not sure it would work here as most of this is the same, but there are It'll reduce a fair amount of test code so I think it's worth it. Looking at the code, I don't think you want a typed test as much as a value parameterized test, since the parameterization is across enum values (rather than distinct classes or types). See https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#value-parameterized-tests for details, and/or grep for TEST_P in the codebase. -- To view, visit http://gerrit.cloudera.org:8080/13869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Gerrit-Change-Number: 13869 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2019 16:22:09 +0000 Gerrit-HasComments: Yes
