Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13911
to review the following change.
Change subject: version_util: track extra delimiter too
......................................................................
version_util: track extra delimiter too
One of the version_util tests verifies that the current version's canonical
representation matches its raw version. The test fails when the delimiter
between the maintenance and extra components is a period, because the
canonical representation builder (i.e. ToString()) assumes that the
delimiter is always a dash.
Rather than weaken the invariant enforced by the unit test, let's track the
parsed delimiter faithfully. I chose to store it separately from the extra
component itself since it didn't logically seem like part of it.
Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549
---
M src/kudu/util/version_util-test.cc
M src/kudu/util/version_util.cc
M src/kudu/util/version_util.h
3 files changed, 30 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/13911/1
--
To view, visit http://gerrit.cloudera.org:8080/13911
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549
Gerrit-Change-Number: 13911
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
