Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13911 )
Change subject: version_util: track extra delimiter too ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13911/2/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/13911/2/src/kudu/util/version_util.cc@44 PS2, Line 44: this->extra_delimiter == other.extra_delimiter && > I don't view this as a "semantic" version comparison; I view it as a canoni Ah, indeed. It seems we semantically compare versions as tuples, doing something like make_tuple(v.major, v.minor, v.maintenance) >= make_tuple(1, 7, 1); -- To view, visit http://gerrit.cloudera.org:8080/13911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Gerrit-Change-Number: 13911 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2019 18:06:06 +0000 Gerrit-HasComments: Yes
