Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13911 )
Change subject: version_util: track extra delimiter too ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13911/2/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/13911/2/src/kudu/util/version_util.cc@44 PS2, Line 44: this->extra_delimiter == other.extra_delimiter && > Do we really want to include the delimiter into the criteria while performi I don't view this as a "semantic" version comparison; I view it as a canonical version comparison. And since the ToString() changes alter the canonical representation to include the delimiter, equality should too. Put another way, I think equality should behave as if we're comparing raw versions. -- To view, visit http://gerrit.cloudera.org:8080/13911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fe983e55ae9f83d075297016ccc5d50c208c549 Gerrit-Change-Number: 13911 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Jul 2019 17:50:37 +0000 Gerrit-HasComments: Yes
