Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 )
Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client ...................................................................... Patch Set 3: (4 comments) Echoing Todd's comments, we don't want to break backwards or forwards compatibility, and I think the changes in meta_cache.cc break compat between old servers and new clients. You might consider splitting up the patch too; there are a number of related but not tightly coupled concerns here (i.e. using ReplicaPB internally, using it on the wire, interning replicas in GetTabletLocationsResponse, etc.) http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: PS3: Doesn't this change mean that old servers (those that don't support this interning) won't be able to communicate with new clients? We'd like to preserve that backwards compatibility. http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/integration-tests/table_locations-itest.cc@250 PS3, Line 250: string tablet_id Capture by cref if you're not using std::move. http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/integration-tests/table_locations-itest.cc@275 PS3, Line 275: get_tablet_location(proxy_.get(), loc.tablet_id()); Need to wrap in NO_FATALS. http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/master/master.proto@a565 PS3, Line 565: I think this comment was useful; could you restore it, and duplicate it into GetTabletLocationsResponsePB? -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 3 Gerrit-Owner: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Comment-Date: Wed, 24 Jul 2019 17:49:02 +0000 Gerrit-HasComments: Yes
