Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 )
Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/13908/6/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/13908/6/src/kudu/client/client.cc@551 PS6, Line 551: for (const auto& r : t.interned_replicas()) { Doesn't this need to also handle the case where we're talking to an old server that doesn't provide interned_replicas? http://gerrit.cloudera.org:8080/#/c/13908/6/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/13908/6/src/kudu/client/meta_cache.cc@196 PS6, Line 196: false Nit: could you add /*failed=*/ just before 'false' here and below? It helps readers understand the meaning of this field. http://gerrit.cloudera.org:8080/#/c/13908/6/src/kudu/client/meta_cache.cc@197 PS6, Line 197: replica std::move http://gerrit.cloudera.org:8080/#/c/13908/6/src/kudu/client/meta_cache.cc@208 PS6, Line 208: replica std::move -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 6 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Fri, 26 Jul 2019 18:35:23 +0000 Gerrit-HasComments: Yes
