Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 )
Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/integration-tests/table_locations-itest.cc@250 PS3, Line 250: const string& ta > Capture by cref if you're not using std::move. Done http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/integration-tests/table_locations-itest.cc@275 PS3, Line 275: NO_FATALS(get_tablet_location(proxy_.get(), loc.tablet_id())); > Need to wrap in NO_FATALS. Done http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/13908/3/src/kudu/master/master.proto@a565 PS3, Line 565: > I think this comment was useful; could you restore it, and duplicate it int Done -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 4 Gerrit-Owner: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Comment-Date: Thu, 25 Jul 2019 07:20:12 +0000 Gerrit-HasComments: Yes