Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 )
Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/13908/8/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/13908/8/src/kudu/client/client.cc@582 PS8, Line 582: RETURN_NOT_OK(add_replica_func(resp.ts_infos(r.ts_info_idx()), r.role(), &replicas)); : } : : unique_ptr<KuduTablet> client_tablet(new KuduTablet); : client_tablet->data_ = new KuduTablet::Data(tablet_id, std::move(replicas)); : replicas.clear(); : > Seems like we could deduplicate this chunk of code too? Done http://gerrit.cloudera.org:8080/#/c/13908/8/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/13908/8/src/kudu/client/meta_cache.cc@198 PS8, Line 198: replicas.push_back(replica); > Hmm, guess I was wrong about std::move here and below. Emm, I think because RemoteReplica's members are pointers and enumerations, so there's no improvement in using std::move. Is that right? -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 9 Gerrit-Owner: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Comment-Date: Mon, 29 Jul 2019 05:53:30 +0000 Gerrit-HasComments: Yes
