Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13908 )
Change subject: [client] Deprecated TabletLocationsPB.ReplicaPB message in client ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/13908/8/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/13908/8/src/kudu/client/client.cc@582 PS8, Line 582: // TODO(aserbin): try to use member_type instead of role for metacache. : bool is_leader = r.role() == consensus::RaftPeerPB::LEADER; : bool is_voter = is_leader || r.role() == consensus::RaftPeerPB::FOLLOWER; : unique_ptr<KuduReplica> replica(new KuduReplica); : replica->data_ = new KuduReplica::Data(is_leader, is_voter, std::move(ts)); : : replicas.push_back(replica.release()); Seems like we could deduplicate this chunk of code too? http://gerrit.cloudera.org:8080/#/c/13908/8/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/13908/8/src/kudu/client/meta_cache.cc@198 PS8, Line 198: replicas.push_back(std::move(replica)); > warning: std::move of the variable 'replica' of the trivially-copyable type Hmm, guess I was wrong about std::move here and below. -- To view, visit http://gerrit.cloudera.org:8080/13908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18272274f07d5ae8e9f6b9572f9900aa8df27bef Gerrit-Change-Number: 13908 Gerrit-PatchSet: 8 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Sun, 28 Jul 2019 21:50:51 +0000 Gerrit-HasComments: Yes
