Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 )
Change subject: [tools] Add delete_column and alter_column tools ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/13976/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13976/3//COMMIT_MSG@13 PS3, Line 13: alter_column kudu table alter_column http://gerrit.cloudera.org:8080/#/c/13976/3//COMMIT_MSG@14 PS3, Line 14: alter_rype alter_type http://gerrit.cloudera.org:8080/#/c/13976/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13976/3/src/kudu/tools/kudu-tool-test.cc@2927 PS3, Line 2927: aler alter http://gerrit.cloudera.org:8080/#/c/13976/3/src/kudu/tools/kudu-tool-test.cc@3283 PS3, Line 3283: workload.Start(); We will not check the writen data, so it's not needed to 'Start' http://gerrit.cloudera.org:8080/#/c/13976/3/src/kudu/tools/kudu-tool-test.cc@3364 PS3, Line 3364: ASSERT_STR_NOT_CONTAINS(table->schema().ToString(), kColumnName); We have to check schema contains this column before deleting it. http://gerrit.cloudera.org:8080/#/c/13976/3/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/13976/3/src/kudu/tools/tool_action_table.cc@174 PS3, Line 174: not_supported, https://google.github.io/styleguide/cppguide.html#Enumerator_Names -- To view, visit http://gerrit.cloudera.org:8080/13976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I228340e46fe48ffc782c4c7346f890444b8c550f Gerrit-Change-Number: 13976 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 01 Aug 2019 08:23:46 +0000 Gerrit-HasComments: Yes
