Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 )
Change subject: [tools] Add table tools to delete column and alter column ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/13976/4/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/13976/4/src/kudu/tools/tool_action_table.cc@710 PS4, Line 710: *value = KuduValue::CopyString(str_value); > I agreed that using Status as return value is more friendly to users, and I Ok. Can you add a comment mentioning that decimal is left out intentionally? Or better yet, have a case for DECIMAL that returns a Status::NotSupported() so users know that decimal isn't supported by this tool yet http://gerrit.cloudera.org:8080/#/c/13976/5/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/13976/5/src/kudu/tools/tool_action_table.cc@86 PS5, Line 86: alter_args nit: so it's extra clear this is referring to columns without reading the description, how about calling this 'alter_column_args'? http://gerrit.cloudera.org:8080/#/c/13976/5/src/kudu/tools/tool_action_table.cc@839 PS5, Line 839: return Status::InvalidArgument(Substitute( : "Invalid block size: $0, it should be set higher than 0.", FLAGS_alter_args)); Can you add negative tests for these, testing that if a user inputs a bad value, the tool will exit with a reasonable error? Same with the other input parsing (e.g. passing in bad values for a given type, passing in bad values for --alter_args). http://gerrit.cloudera.org:8080/#/c/13976/5/src/kudu/tools/tool_action_table.cc@1008 PS5, Line 1008: unique_ptr<Action> alter_column = nit: fix indentation here -- To view, visit http://gerrit.cloudera.org:8080/13976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I228340e46fe48ffc782c4c7346f890444b8c550f Gerrit-Change-Number: 13976 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 08 Aug 2019 19:21:47 +0000 Gerrit-HasComments: Yes
