Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 )
Change subject: [tools] Add table tools to delete column and alter column ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/13976/4/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/13976/4/src/kudu/tools/tool_action_table.cc@710 PS4, Line 710: } > Ok. Can you add a comment mentioning that decimal is left out intentionally Done http://gerrit.cloudera.org:8080/#/c/13976/5/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/13976/5/src/kudu/tools/tool_action_table.cc@86 PS5, Line 86: alter_colu > nit: so it's extra clear this is referring to columns without reading the d Done http://gerrit.cloudera.org:8080/#/c/13976/5/src/kudu/tools/tool_action_table.cc@839 PS5, Line 839: } : case AlterType::SET_ENCODING: { > Can you add negative tests for these, testing that if a user inputs a bad v Done http://gerrit.cloudera.org:8080/#/c/13976/5/src/kudu/tools/tool_action_table.cc@1008 PS5, Line 1008: "If > nit: fix indentation here Done -- To view, visit http://gerrit.cloudera.org:8080/13976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I228340e46fe48ffc782c4c7346f890444b8c550f Gerrit-Change-Number: 13976 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Mon, 12 Aug 2019 10:53:22 +0000 Gerrit-HasComments: Yes
