Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 )
Change subject: [tools] Add table tools to delete column and alter column ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/13976/6/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/13976/6/src/kudu/tools/tool_action_table.cc@698 PS6, Line 698: RETURN_NOT_OK_PREPEND( > Just to clarify: with the new JSON encoding, empty strings are treated as v Yes. I have added a few tests. http://gerrit.cloudera.org:8080/#/c/13976/9/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/13976/9/src/kudu/tools/tool_action_table.cc@173 PS9, Line 173: enum PartitionAction { > We try to avoid declaring global non-POD-type variables. They're not so muc Done http://gerrit.cloudera.org:8080/#/c/13976/9/src/kudu/tools/tool_action_table.cc@706 PS9, Line 706: reader.ExtractBool(values[0], /*field=*/nullptr, &bool_value), msg); : *value = KuduValue::FromBool(bool_value); > Maybe you can declare this up front so you needn't duplicate it in multiple Done http://gerrit.cloudera.org:8080/#/c/13976/9/src/kudu/tools/tool_action_table.cc@767 PS9, Line 767: } > Could you add a comment here explaining that we're not actually interested Done http://gerrit.cloudera.org:8080/#/c/13976/9/src/kudu/tools/tool_action_table.cc@797 PS9, Line 797: : Status ColumnSetEncoding(const RunnerCon > Should be able to use one of the FindOr* functions from gutil/map-util.h he Done -- To view, visit http://gerrit.cloudera.org:8080/13976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I228340e46fe48ffc782c4c7346f890444b8c550f Gerrit-Change-Number: 13976 Gerrit-PatchSet: 10 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2019 11:46:19 +0000 Gerrit-HasComments: Yes
