Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13976 )
Change subject: [tools] Add table tools to delete column and alter column ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/13976/6/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/13976/6/src/kudu/tools/tool_action_table.cc@86 PS6, Line 86: DEFINE_string(alter_column_args, "", : "Args of alter operation on the column."); > I think it's a good idea. Good question. We have implemented "sub-modes" (i.e. mode within another mode) in a few places, but there has been some pushback from folks who think that it makes it more difficult to discover functionality. Furthermore, rename_column was added in 1.8.0 so moving it into a sub-mode would represent a compatibility break in the CLI. Probably not a major one, but an inconvenient one nonetheless. So I think I'd vote for keeping all of the column actions rooted in the 'table' mode. But I'm open to changing it if others feel strongly about adding a 'column' sub-mode. -- To view, visit http://gerrit.cloudera.org:8080/13976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I228340e46fe48ffc782c4c7346f890444b8c550f Gerrit-Change-Number: 13976 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2019 18:54:23 +0000 Gerrit-HasComments: Yes
