Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc File src/kudu/util/compression/compression-test.cc: http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@81 PS4, Line 81: const int kMaterialCount = 16; : const int kInputSize = 8; : const int kSliceCount = 1024; nit: use 'const consexpr' for the constants? https://en.cppreference.com/w/cpp/language/constexpr http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@120 PS4, Line 120: total_len >> 20 I'm curious whether this up-to-MB rounding might hide performance boost from switching to the newer version of the lz4 library? http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@136 PS4, Line 136: total_len >> 10 ditto -- To view, visit http://gerrit.cloudera.org:8080/14086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12 Gerrit-Change-Number: 14086 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2019 16:59:48 +0000 Gerrit-HasComments: Yes
