Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc File src/kudu/util/compression/compression-test.cc: http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@81 PS4, Line 81: const int kMaterialCount = 16; : const int kInputSize = 8; : const int kSliceCount = 1024; > nit: Done http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@120 PS4, Line 120: total_len >> 20 > I'm curious whether this up-to-MB rounding might hide performance boost fr On my platform, Intel Xeon E5-2620 v3, CentOS 7.3.1611, benchmark output: I0820 10:06:46.046753 92829 compression-test.cc:121] SNAPPY compress throughput: 254.361 MB/sec, ratio: 0.256226 I0820 10:06:49.046949 92829 compression-test.cc:137] SNAPPY uncompress throughput: 1346.23 KB/sec I0820 10:06:52.047041 92829 compression-test.cc:121] LZ4 compress throughput: 415.709 MB/sec, ratio: 0.364502 I0820 10:06:55.047103 92829 compression-test.cc:137] LZ4 uncompress throughput: 1955 KB/sec I0820 10:06:58.047474 92829 compression-test.cc:121] ZLIB compress throughput: 18.6865 MB/sec, ratio: 0.150879 I0820 10:07:01.047546 92829 compression-test.cc:137] ZLIB uncompress throughput: 94.2997 KB/sec Thoughtput of new LZ4 is about 415.709 MB/sec, since it's a double type and value is several hundreds, performance improvment will not hide much. http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@136 PS4, Line 136: total_len >> 10 > ditto The same. And you remind me to reconsider uncompression calculate method. Now, output looks like: I0820 10:36:41.497403 81986 compression-test.cc:121] SNAPPY compress throughput: 256.966 MB/sec, ratio: 0.257446 I0820 10:36:44.497658 81986 compression-test.cc:137] SNAPPY uncompress throughput: 1350.52 MB/sec I0820 10:36:47.497826 81986 compression-test.cc:121] LZ4 compress throughput: 415.471 MB/sec, ratio: 0.366089 I0820 10:36:50.497938 81986 compression-test.cc:137] LZ4 uncompress throughput: 1958.92 MB/sec I0820 10:36:53.498111 81986 compression-test.cc:121] ZLIB compress throughput: 18.3828 MB/sec, ratio: 0.149536 I0820 10:36:56.498231 81986 compression-test.cc:137] ZLIB uncompress throughput: 94.4513 MB/sec -- To view, visit http://gerrit.cloudera.org:8080/14086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12 Gerrit-Change-Number: 14086 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2019 02:40:09 +0000 Gerrit-HasComments: Yes
