Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Will defer to Alexey. http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc File src/kudu/util/compression/compression-test.cc: http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@123 PS1, Line 123: } > I saw implemention of LOG_TIMING, but the internal stopwatch couldn't be ex Fair point. -- To view, visit http://gerrit.cloudera.org:8080/14086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12 Gerrit-Change-Number: 14086 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2019 18:54:52 +0000 Gerrit-HasComments: Yes
