Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 )
Change subject: Create kudu/rebalance subdirectory ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/cluster_status.h File src/kudu/rebalance/cluster_status.h: http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/cluster_status.h@36 PS9, Line 36: // The result of health check on a tablet. : // Also used to indicate the health of a table, since the health of a table is : // the health of its least healthy tablet. : enum class ClusterCheckResult { : // The tablet is healthy. : HEALTHY, : : // The tablet has on-going tablet copies. : RECOVERING, : : // The tablet has fewer replicas than its table's replication factor and : // has no on-going tablet copies. : UNDER_REPLICATED, : : // The tablet is missing a majority of its replicas and is unavailable for : // writes. If a majority cannot be brought back online, then the tablet : // requires manual intervention to recover. : UNAVAILABLE, : : // There was a discrepancy among the tablets' consensus configs and the master's. : CONSENSUS_MISMATCH, : }; > I'm OK with leaving it currently under src/kudu/rebalancer. You can shop a Done http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/rebalancer.h File src/kudu/rebalance/rebalancer.h: http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/rebalancer.h@47 PS9, Line 47: class Rebalancer { > Great! Could you add the gist of it this in the form of a short comments f Done -- To view, visit http://gerrit.cloudera.org:8080/14110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0242a019cb44517539da2878cf889ee0c511964 Gerrit-Change-Number: 14110 Gerrit-PatchSet: 9 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 26 Aug 2019 15:57:56 +0000 Gerrit-HasComments: Yes
