Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 )
Change subject: Create kudu/rebalance subdirectory ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/14110/10/src/kudu/rebalance/cluster_status.cc File src/kudu/rebalance/cluster_status.cc: PS10: We chatted about this offline: there is already a cluster namespace; maybe we should consider using something else? Maybe cluster_summary? cluster_health? http://gerrit.cloudera.org:8080/#/c/14110/10/src/kudu/rebalance/rebalance_algo-test.cc File src/kudu/rebalance/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/14110/10/src/kudu/rebalance/rebalance_algo-test.cc@44 PS10, Line 44: : namespace kudu { : namespace rebalance { : struct TestClusterConfig; : } // namespace rebalance : } // namespace kudu Can this be moved into the below rebalance namespace? http://gerrit.cloudera.org:8080/#/c/14110/10/src/kudu/tools/ksck_results.h File src/kudu/tools/ksck_results.h: http://gerrit.cloudera.org:8080/#/c/14110/10/src/kudu/tools/ksck_results.h@148 PS10, Line 148: const std::vector<cluster::ServerHealthSummary>& : summaries, nit: could you keep these on the same line? http://gerrit.cloudera.org:8080/#/c/14110/10/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: http://gerrit.cloudera.org:8080/#/c/14110/10/src/kudu/tools/ksck_results.cc@714 PS10, Line 714: nit: spacing here and below -- To view, visit http://gerrit.cloudera.org:8080/14110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0242a019cb44517539da2878cf889ee0c511964 Gerrit-Change-Number: 14110 Gerrit-PatchSet: 10 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 26 Aug 2019 23:52:51 +0000 Gerrit-HasComments: Yes
