Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 )
Change subject: Create kudu/rebalance subdirectory ...................................................................... Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/rebalance-test.cc File src/kudu/rebalance/rebalance-test.cc: http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/rebalance-test.cc@182 PS9, Line 182: return HasSameContents(lhs.servers_by_replica_count, : rhs.servers_by_replica_count); > nit: indentation Done http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/rebalancer.h File src/kudu/rebalance/rebalancer.h: http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/rebalancer.h@19 PS9, Line 19: #include <stddef.h> : #include <stdint.h> > nit here and elsewhere when using IWYU suggestions: please use C++-style in Done http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/rebalancer.h@47 PS9, Line 47: class Rebalancer { > Add short documentation for the class. The important point is to explain w A Rebalancer object is a member variable of the class master::AutoRebalancerTask, but is the base class of tools:RebalancerTool. RebalancerTool object has some additional functions for printing balance information. AutoRebalancerTask is a thread that manages the Rebalancer object. http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/rebalancer.cc File src/kudu/rebalance/rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/rebalance/rebalancer.cc@57 PS9, Line 57: std::vector<std::string> ignored_tservers_param, : std::vector<std::string> master_addresses, : std::vector<std::string> table_filters, > nit: remove std:: namespace prefix since there are corresponding 'using std Done http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/tools/ksck_results.cc@714 PS9, Line 714: > nit: indent/spacing Done http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/tools/ksck_results.cc@746 PS9, Line 746: > nit: indent/spacing Done http://gerrit.cloudera.org:8080/#/c/14110/9/src/kudu/tools/ksck_results.cc@781 PS9, Line 781: > nit: indent/spacing Done -- To view, visit http://gerrit.cloudera.org:8080/14110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0242a019cb44517539da2878cf889ee0c511964 Gerrit-Change-Number: 14110 Gerrit-PatchSet: 9 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 25 Aug 2019 16:57:48 +0000 Gerrit-HasComments: Yes
