Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 )
Change subject: WIP KUDU-2780: create thread for auto-rebalancing ...................................................................... Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer-test.cc@18 PS1, Line 18: #include "kudu/master/autorebalancer.h" > error: 'kudu/master/autorebalancer.h' file not found [clang-diagnostic-erro Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@48 PS1, Line 48: #include "kudu/util/flags.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@61 PS1, Line 61: using kudu::rebalance::ClusterBalanceInfo; > warning: using decl 'ClusterBalanceInfo' is unused [misc-unused-using-decls Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@67 PS1, Line 67: using std::endl; > warning: using decl 'endl' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@68 PS1, Line 68: using std::map; > warning: using decl 'map' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@69 PS1, Line 69: using std::numeric_limits; > warning: using decl 'numeric_limits' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@70 PS1, Line 70: using std::pair; > warning: using decl 'pair' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@71 PS1, Line 71: using std::set; > warning: using decl 'set' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@72 PS1, Line 72: using std::shared_ptr; > warning: using decl 'shared_ptr' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@74 PS1, Line 74: using std::to_string; > warning: using decl 'to_string' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@75 PS1, Line 75: using std::unordered_map; > warning: using decl 'unordered_map' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/auto_rebalancer.cc@108 PS1, Line 108: string master_addresses_str) > warning: the parameter 'master_addresses_str' is copied for each invocation Done http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14177/1/src/kudu/master/catalog_manager.cc@788 PS1, Line 788: auto_rebalancer_.reset(new AutoRebalancerTask(this, master_addresses)); > warning: 'master_addresses' used after it was moved [bugprone-use-after-mov Done -- To view, visit http://gerrit.cloudera.org:8080/14177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifca25d1063c07047cf2123e6792b3c7395be20e4 Gerrit-Change-Number: 14177 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 04 Sep 2019 23:23:24 +0000 Gerrit-HasComments: Yes
