Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 )
Change subject: WIP KUDU-2780: create thread for auto-rebalancing ...................................................................... Patch Set 2: Some more notes on high-level approach. Consider hide/encapsulate the complexity of the internal state of the rebalancing process within Rebalancer/RebalancerTool or similar wrapper, and have some sort of approach where the thread simply calls something like DoNextStep(). Basically, that would give a simpler logic and clear structure of code where the rebalancing thread simply 'pushes' the rebalancing process forward when master is leader. It's not necessary to sleep between those 'atomic' steps. I think the only time when it's necessary to sleep for longer interval (i.e. --auto_rebalancing_interval_seconds) between full rebalancing cycles. Adding the maximum number of moves in flight is a good enough restriction in addition to --max_moves_per_server (the latter is already present in current version of the rebalancer tool). -- To view, visit http://gerrit.cloudera.org:8080/14177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifca25d1063c07047cf2123e6792b3c7395be20e4 Gerrit-Change-Number: 14177 Gerrit-PatchSet: 2 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 05 Sep 2019 23:12:54 +0000 Gerrit-HasComments: No
