Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 )
Change subject: WIP KUDU-2780: create thread for auto-rebalancing ...................................................................... Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer-test.cc@31 PS2, Line 31: using kudu::cluster::ExternalMiniClusterOptions; > warning: using decl 'ExternalMiniClusterOptions' is unused [misc-unused-usi Done http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer-test.cc@32 PS2, Line 32: using std::unique_ptr; > warning: using decl 'unique_ptr' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer.h File src/kudu/master/auto_rebalancer.h: http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer.h@66 PS2, Line 66: explicit > nit: I don't think explicit is needed here since it's hard to write somethi Done http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer.cc@165 PS2, Line 165: if (!catalog_manager_) continue; > How could it happen that catalog_manager_ is nullptr? And if so, wouldn't Done http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer.cc@168 PS2, Line 168: CatalogManager::ScopedLeaderSharedLock l(catalog_manager_); > As it's written now, the scope of this lock is too wide -- it will take a w Done http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer.cc@171 PS2, Line 171: // TODO(hannah.nguyen): holding onto this lock too long? : // Concerning especially if replica moves aren't async. > Since this lock is used only to synchronize access to closing_ by this meth Done http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer.cc@183 PS2, Line 183: (!BuildClusterRawInfo(boost::none, &raw_info).ok()) > Does it deserve some logging if it was not possible to get a snapshot of th Done http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer.cc@190 PS2, Line 190: \ > drop Done http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer.cc@210 PS2, Line 210: > nit: this extra line isn't good for readability Done http://gerrit.cloudera.org:8080/#/c/14177/2/src/kudu/master/auto_rebalancer.cc@246 PS2, Line 246: > nit here and 3 closing parenthesis above: an extra empty line Done -- To view, visit http://gerrit.cloudera.org:8080/14177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifca25d1063c07047cf2123e6792b3c7395be20e4 Gerrit-Change-Number: 14177 Gerrit-PatchSet: 2 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 08 Sep 2019 01:00:19 +0000 Gerrit-HasComments: Yes
