Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14232 )
Change subject: [tserver] include ip:port in the tserver name ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14232/2/src/kudu/tserver/tablet_server.cc File src/kudu/tserver/tablet_server.cc: http://gerrit.cloudera.org:8080/#/c/14232/2/src/kudu/tserver/tablet_server.cc@69 PS2, Line 69: if (kRunning != state_) { : return "TabletServer (stopped)"; : } : return strings::Substitute("TabletServer@$0", first_rpc_address().ToString()); Maybe, this is a good opportunity to consolidate implementation of corresponding methods for both Master and TabletServer into kserver::KuduServer::ToString() ? -- To view, visit http://gerrit.cloudera.org:8080/14232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b0d8e29b6cac5a900923b881f0d7a74facbd6e Gerrit-Change-Number: 14232 Gerrit-PatchSet: 2 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Sep 2019 16:42:35 +0000 Gerrit-HasComments: Yes
