Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/14232 )
Change subject: [tserver] include ip:port in the tserver name
......................................................................
Patch Set 3:
> > (1 comment)
> >
> > The TSAN failure is interesting. It's not related to this patch,
> > but it is related to one of your previous patches, Lifu.
> >
> > In ts_tablet_manager-itest.cc:
> >
> > // 6. Restart the masters.
> > {
> > for (int i = 0; i < kNumMasters; ++i) {
> > int idx = 0;
> > ASSERT_OK(cluster_->GetLeaderMasterIndex(&idx));
> > master::MiniMaster* mini_master =
> CHECK_NOTNULL(cluster_->mini_master(idx));
> > mini_master->Shutdown();
> > SleepFor(MonoDelta::FromMilliseconds(kMaxElectionTime));
> > ASSERT_OK(mini_master->Restart());
> > // Sometimes the election fails until the node restarts.
> > // And the restarted node is elected leader again.
> > // So, it is necessary to wait for all tservers to report.
> > SleepFor(MonoDelta::FromMilliseconds(FLAGS_heartbeat_interval_ms));
> > NO_FATALS(CheckStats(kRowsCount));
> > }
> > }
> >
> > I think there needs to be a call to
> mini_master->WaitForCatalogManagerInit()
> > somewhere, perhaps after the Restart(), or after the waiting.
>
> The test case here only cares about the leader master, so I don't think it's
> necessary to make sure the restarted master should be online, that means
> calling "mini_master->WaitForCatalogManagerInit()" is not required. Besides,
> there is evidence that the restarted master had been online before failure,
> please look at the full test output from Line2136 to Line2168.
Not sure I agree with your assessment, but in any case, I've filed KUDU-2944
where we can debug further.
--
To view, visit http://gerrit.cloudera.org:8080/14232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b0d8e29b6cac5a900923b881f0d7a74facbd6e
Gerrit-Change-Number: 14232
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <[email protected]>
Gerrit-Comment-Date: Tue, 17 Sep 2019 20:58:21 +0000
Gerrit-HasComments: No
