Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14232 )
Change subject: [tserver] include ip:port in the tserver name ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14232/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14232/3//COMMIT_MSG@7 PS3, Line 7: [tserver] include ip:port in the tserver name Update this to reflect the new behavior of the commit. http://gerrit.cloudera.org:8080/#/c/14232/3/src/kudu/server/rpc_server.h File src/kudu/server/rpc_server.h: http://gerrit.cloudera.org:8080/#/c/14232/3/src/kudu/server/rpc_server.h@82 PS3, Line 82: std::string RpcAddresses() const; Could you restore the ToString() name? ToString() is a strong convention within Kudu, and RpcAddresses() sounds like the name of a constructor. http://gerrit.cloudera.org:8080/#/c/14232/3/src/kudu/server/rpc_server.cc File src/kudu/server/rpc_server.cc: http://gerrit.cloudera.org:8080/#/c/14232/3/src/kudu/server/rpc_server.cc@111 PS3, Line 111: string rpc_addresses; You should be able to simplify this using a function from gutil/strings/join.h. Perhaps JoinMapped? -- To view, visit http://gerrit.cloudera.org:8080/14232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b0d8e29b6cac5a900923b881f0d7a74facbd6e Gerrit-Change-Number: 14232 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 17 Sep 2019 21:31:48 +0000 Gerrit-HasComments: Yes
