Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14252 )
Change subject: KUDU-2934: add MeanGauge type to metrics ...................................................................... Patch Set 1: (4 comments) The test failure is unrelated to your patch; I published http://gerrit.cloudera.org:8080/14256 for it. http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/tablet/rowset_info.h File src/kudu/tablet/rowset_info.h: http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/tablet/rowset_info.h@58 PS1, Line 58: MeanValue* rowset_height, I don't think rowset_info.{cc,h} needs to be exposed to this metric detail. Let's just pass in two double pointers to get the parts of the average height out of the function. http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/util/metrics.h@979 PS1, Line 979: class MeanValue { Could we get by without this? Seems like we could bake the relevant functionality directly into the MeanGauge. http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/util/metrics.h@1017 PS1, Line 1017: OVERRIDE Nit: "override" for new code. http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/util/metrics.cc@753 PS1, Line 753: return true; I can't find a single MergeFrom() that returns false. In a separate patch could you modify it to be a void function? -- To view, visit http://gerrit.cloudera.org:8080/14252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I827d3acb5d4f47a7e28ac40cb7df392c29c82a40 Gerrit-Change-Number: 14252 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 18 Sep 2019 19:31:00 +0000 Gerrit-HasComments: Yes
