Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14252 )
Change subject: KUDU-2934: add MeanGauge type to metrics ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/tablet/rowset_info.h File src/kudu/tablet/rowset_info.h: http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/tablet/rowset_info.h@58 PS1, Line 58: double* rowset_total_height, > I don't think rowset_info.{cc,h} needs to be exposed to this metric detail. Done http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/util/metrics.h@979 PS1, Line 979: class MeanGauge : public Gauge { > Could we get by without this? Seems like we could bake the relevant functio Done http://gerrit.cloudera.org:8080/#/c/14252/1/src/kudu/util/metrics.h@1017 PS1, Line 1017: > Nit: "override" for new code. Done -- To view, visit http://gerrit.cloudera.org:8080/14252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I827d3acb5d4f47a7e28ac40cb7df392c29c82a40 Gerrit-Change-Number: 14252 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 20 Sep 2019 02:37:31 +0000 Gerrit-HasComments: Yes
