Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14252
to look at the new patch set (#2).
Change subject: KUDU-2934: add MeanGauge type to metrics
......................................................................
KUDU-2934: add MeanGauge type to metrics
The current merge method is not suitable for the metric
'average_diskrowset_height', it is a mean value and we
could not just sum up the metric values when merging
metrics.
There is another issue with the metric 'average_diskrowset_height',
the value of the metric is double but it was used as an AtomicGauge
metric, which is only for types that are convertible to/from int64_t.
This patch added a new 'MeanGauge' type for metrics which show
the mean value of something.
Change-Id: I827d3acb5d4f47a7e28ac40cb7df392c29c82a40
---
M src/kudu/tablet/compaction_policy-test.cc
M src/kudu/tablet/compaction_policy.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/rowset_info.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
10 files changed, 167 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/14252/2
--
To view, visit http://gerrit.cloudera.org:8080/14252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I827d3acb5d4f47a7e28ac40cb7df392c29c82a40
Gerrit-Change-Number: 14252
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
