Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14263 )
Change subject: KUDU-2842: don't reference CowLock state from TSInfosDict ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14263/1//COMMIT_MSG Commit Message: PS1: > Could you rerun the benchmark from KUDU-2711 and compare before/after resul Done http://gerrit.cloudera.org:8080/#/c/14263/1/src/kudu/gutil/map-util.h File src/kudu/gutil/map-util.h: http://gerrit.cloudera.org:8080/#/c/14263/1/src/kudu/gutil/map-util.h@890 PS1, Line 890: // s->set_string(my_key); > What's 'si'? Did you mean 's'? Also, isn't it UB to use 's' in the first ar Done http://gerrit.cloudera.org:8080/#/c/14263/1/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/14263/1/src/kudu/integration-tests/table_locations-itest.cc@391 PS1, Line 391: TEST_F(TableLocationsTest, GetTableLocationsBenchmark) { > Need to fill this in? Yeah, this was a draft post. http://gerrit.cloudera.org:8080/#/c/14263/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14263/1/src/kudu/master/catalog_manager.cc@4851 PS1, Line 4851: int ts_info_idx = ts_info_pbs.size(); > While you're here could you rename this variable so it doesn't share the sa Done -- To view, visit http://gerrit.cloudera.org:8080/14263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30f4cd2eb8439e1923c1c2617248514354561d16 Gerrit-Change-Number: 14263 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 20 Sep 2019 00:55:23 +0000 Gerrit-HasComments: Yes
