Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14263 )
Change subject: KUDU-2842: don't reference CowLock state from TSInfosDict ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14263/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/14263/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc@278 PS4, Line 278: enum WithConcurrentGetTableLocations { : YES, : NO, : }; Why not just have the test unconditionally hammer the master? What's the purpose of having a variant with the extra thread and a variant without? http://gerrit.cloudera.org:8080/#/c/14263/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc@351 PS4, Line 351: WARN_NOT_OK(master_proxy->GetTableLocations(req, &resp, &rpc), "Failed to send request"); Could just ignore_result() here then. Do we actually want those warnings in the test log? http://gerrit.cloudera.org:8080/#/c/14263/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14263/4/src/kudu/master/catalog_manager.cc@4848 PS4, Line 4848: [&]() -> std::pair<StringPiece, int> { Why did you have to remove const here, and use a temporary StringPiece on L4853? -- To view, visit http://gerrit.cloudera.org:8080/14263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30f4cd2eb8439e1923c1c2617248514354561d16 Gerrit-Change-Number: 14263 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 20 Sep 2019 04:09:43 +0000 Gerrit-HasComments: Yes
