Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14263 )
Change subject: KUDU-2842: don't reference CowLock state from TSInfosDict ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/14263/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/14263/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc@278 PS4, Line 278: class LeadershipChangeReportingTest : public TsTabletManagerITest { : public: : const int kNumReplicas = 2; : > Why not just have the test unconditionally hammer the master? What's the pu Ugh, I completely overestimated this test. It's not testing the code paths I thought it was. Will rejigger. http://gerrit.cloudera.org:8080/#/c/14263/4/src/kudu/integration-tests/ts_tablet_manager-itest.cc@351 PS4, Line 351: } > Could just ignore_result() here then. Do we actually want those warnings in Done http://gerrit.cloudera.org:8080/#/c/14263/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14263/4/src/kudu/master/catalog_manager.cc@4848 PS4, Line 4848: [&]() -> pair<StringPiece, int> { > Why did you have to remove const here, and use a temporary StringPiece on L Without the temporary, make_pair isn't smart enough to infer the StringPiece type (even though the return type is pair<StringPiece, int>. I don't know why). I could explicitly bind types to make_pair, but then it complains about wanting an int&& type (I could std::move(ts_info_idx), but that just feels wrong). I updated this to not use make_pair, since I think that's the source of my troubles. const StringPiece vs StringPiece doesn't matter in this context. -- To view, visit http://gerrit.cloudera.org:8080/14263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30f4cd2eb8439e1923c1c2617248514354561d16 Gerrit-Change-Number: 14263 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 20 Sep 2019 07:11:50 +0000 Gerrit-HasComments: Yes
