Yingchun Lai has uploaded this change for review. (
http://gerrit.cloudera.org:8080/14277
Change subject: [tools] Set extra-configs by JSON string
......................................................................
[tools] Set extra-configs by JSON string
When attempt to set a extra config to a negative number, the minus
will be parsed by gflags first, and then report an error, even if
it is wrapped by quotations marks.
e.g.
$ kudu table set_extra_config @onebox test_table
kudu.table.maintenance_priority -1
ERROR: unknown command line flag '1'
This patch fixes this bug by passing a JSON string, and also support to
set multiple extra-configs. e.g.
$ kudu table set_extra_configs @onebox test_table
'{"kudu.table.history_max_age_sec":"3600","kudu.table.maintenance_priority":"-1"}'
Change-Id: I3cc9a4c54d43bb0e0c67f42a2055b24b6f5f3f01
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/util/jsonreader-test.cc
M src/kudu/util/jsonreader.cc
M src/kudu/util/jsonreader.h
6 files changed, 121 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/14277/1
--
To view, visit http://gerrit.cloudera.org:8080/14277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cc9a4c54d43bb0e0c67f42a2055b24b6f5f3f01
Gerrit-Change-Number: 14277
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <[email protected]>
