Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14277 )
Change subject: [tools] Set extra-configs by JSON string ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14277/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14277/1//COMMIT_MSG@9 PS1, Line 9: When attempt to set a extra config to a negative number, the minus : will be parsed by gflags first, and then report an error, even if : it is wrapped by quotations marks. The gflags docs[1]: As in getopt(), -- by itself will terminate flags processing. So in foo -f1 1 -- -f2 2, f1 is considered a flag, but -f2 is not. Did you try "kudu table set_extra_config @onebox test_table kudu.table.maintenance_priority -- -1"? 1. https://gflags.github.io/gflags/ -- To view, visit http://gerrit.cloudera.org:8080/14277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cc9a4c54d43bb0e0c67f42a2055b24b6f5f3f01 Gerrit-Change-Number: 14277 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 21 Sep 2019 22:15:11 +0000 Gerrit-HasComments: Yes
