Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14277 )
Change subject: [tools] Set extra-configs by JSON string ...................................................................... Patch Set 1: > Patch Set 1: > > (1 comment) Thanks for your info! Now I try it, and it wokrs roughly speaking. There is a argv rearrangment[1] when gflag parse command line, arguments before and after "--" will be swaped, e.g. "kudu table set_extra_config @onebox test_table kudu.table.maintenance_priority -- -1" will be rearranged as: "kudu -1 table set_extra_config @onebox test_table kudu.table.maintenance_priority", and this will report "Invalid argument: unknown command '-1'" However we can use command: "kudu -- table set_extra_config @onebox test_table kudu.table.maintenance_priority -1" which will be rearanged as: "kudu table set_extra_config @onebox test_table kudu.table.maintenance_priority -1", and it works. So, I'll abandon this CR. 1. https://github.com/gflags/gflags/blob/b051bace27a6ac03fc0cbbeef117fe1d375aca1b/src/gflags.h.in#L341 -- To view, visit http://gerrit.cloudera.org:8080/14277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cc9a4c54d43bb0e0c67f42a2055b24b6f5f3f01 Gerrit-Change-Number: 14277 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 22 Sep 2019 11:11:09 +0000 Gerrit-HasComments: No
