Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7477 )
Change subject: [clock] add a built-in NTP client implementation ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/7477/13/src/kudu/clock/builtin_ntp.cc File src/kudu/clock/builtin_ntp.cc: http://gerrit.cloudera.org:8080/#/c/7477/13/src/kudu/clock/builtin_ntp.cc@572 PS13, Line 572: memcpy(&resp, buf, sizeof(NtpPacket)); > Ah, ignore the step 2 above: it seems the recvfrom() should just discard th After looking into the code again I realized that since we are not discarding larger packets anyways, reading right into the packet structure is different only by that VLOG(1) message and doesn't affect the actual functionality anyways. -- To view, visit http://gerrit.cloudera.org:8080/7477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb9eee9f0334236f39617492bd6f01304d1a0255 Gerrit-Change-Number: 7477 Gerrit-PatchSet: 13 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 25 Sep 2019 23:59:39 +0000 Gerrit-HasComments: Yes
