Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7477 )
Change subject: [clock] add a built-in NTP client implementation ...................................................................... Patch Set 21: (3 comments) http://gerrit.cloudera.org:8080/#/c/7477/21/src/kudu/clock/builtin_ntp.cc File src/kudu/clock/builtin_ntp.cc: http://gerrit.cloudera.org:8080/#/c/7477/21/src/kudu/clock/builtin_ntp.cc@504 PS21, Line 504: Status BuiltInNtp::Init() { Now that we can guarantee that Init() is only called once, I don't think we need to protect against the "multiple call to Init" case. At least, we could do it with a DCHECK or CHECK rather than a runtime failure. http://gerrit.cloudera.org:8080/#/c/7477/21/src/kudu/clock/builtin_ntp.cc@627 PS21, Line 627: impelement implement http://gerrit.cloudera.org:8080/#/c/7477/21/src/kudu/clock/builtin_ntp.cc@659 PS21, Line 659: // The IO loop of this implementation (see BuiltInNtp::PollThread() method) : // doesn't allow for IO multiplexing, so this short SO_RCVTIMEO timeout is set : // to avoid blocking the IO loop at the receiving phase when there is data : // to be sent. Does this mean that Shutdown() may block for up to 0.5s? If/when every server runs one of these, that time may add up and slow down tests. Could we address that by making the socket I/O non-blocking and use something like libev to simultaneously wait for socket activity as well as Shutdown() calls? Not something we need to address here, but something to think about. -- To view, visit http://gerrit.cloudera.org:8080/7477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb9eee9f0334236f39617492bd6f01304d1a0255 Gerrit-Change-Number: 7477 Gerrit-PatchSet: 21 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 30 Sep 2019 21:48:23 +0000 Gerrit-HasComments: Yes
