Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7477 )
Change subject: [clock] add a built-in NTP client implementation ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/7477/19/src/kudu/clock/builtin_ntp.h File src/kudu/clock/builtin_ntp.h: http://gerrit.cloudera.org:8080/#/c/7477/19/src/kudu/clock/builtin_ntp.h@105 PS19, Line 105: returninig returning http://gerrit.cloudera.org:8080/#/c/7477/19/src/kudu/clock/builtin_ntp.h@105 PS19, Line 105: multple multiple http://gerrit.cloudera.org:8080/#/c/7477/19/src/kudu/clock/builtin_ntp.h@107 PS19, Line 107: Status Prepare(); Having to distinguish between Prepare (just one call) and Init (repeated calls) got me thinking: could we implement the "wait for time sync" loop with just one call to Init for setup followed by multiple calls to WalltimeWithError to figure out if time is synchronized? That should simplify this. -- To view, visit http://gerrit.cloudera.org:8080/7477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb9eee9f0334236f39617492bd6f01304d1a0255 Gerrit-Change-Number: 7477 Gerrit-PatchSet: 19 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2019 05:13:01 +0000 Gerrit-HasComments: Yes
