Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14322 )
Change subject: cfile: track memory for CFileReaders and BloomFileReaders ...................................................................... Patch Set 3: > Patch Set 3: > > Not sure why you needed the change to FindOrCreateMemTracker. Couldn't you > modify TabletMemTrackers to include new CFileReaders and BloomFileReaders > trackers (parented to the per-tablet tracker), then update some references to > tablet_tracker with the new trackers? > > Some light plumbing work will also be needed in CFileSet::Open (needs to pass > down both new trackers), though you could make that a one-time cost by > passing down TabletMemTrackers instead. Makes me sad that it was that easy and this has been around for so long :/ I'll opt to not plumb the TabletMemTrackers down; seems like a pain dealing with the dependencies. -- To view, visit http://gerrit.cloudera.org:8080/14322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c89079edffb41d1f5b40d7b699c525fa447a7 Gerrit-Change-Number: 14322 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 01 Oct 2019 18:05:03 +0000 Gerrit-HasComments: No
