Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14322 )
Change subject: cfile: track memory for CFileReaders and BloomFileReaders ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14322/4/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: PS4: > How about passing the two new trackers into CFileSet directly in lieu of th Done http://gerrit.cloudera.org:8080/#/c/14322/4/src/kudu/tablet/tablet_mem_trackers.h File src/kudu/tablet/tablet_mem_trackers.h: http://gerrit.cloudera.org:8080/#/c/14322/4/src/kudu/tablet/tablet_mem_trackers.h@41 PS4, Line 41: std::move(parent_mem_tracker))), > warning: parameter 'parent_mem_tracker' is passed by value and only copied Done -- To view, visit http://gerrit.cloudera.org:8080/14322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c89079edffb41d1f5b40d7b699c525fa447a7 Gerrit-Change-Number: 14322 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 01 Oct 2019 21:45:56 +0000 Gerrit-HasComments: Yes
