Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14322 )
Change subject: cfile: track memory for CFileReaders and BloomFileReaders ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14322/4/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: PS4: How about passing the two new trackers into CFileSet directly in lieu of the FindTracker() call? Doing so will make the tracker dependency more clear and avoid the duplication of the special "CFileReaders" and "BloomFileReaders" string constants. -- To view, visit http://gerrit.cloudera.org:8080/14322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c89079edffb41d1f5b40d7b699c525fa447a7 Gerrit-Change-Number: 14322 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 01 Oct 2019 21:09:10 +0000 Gerrit-HasComments: Yes
