Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14050 )
Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4 ...................................................................... Patch Set 16: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java File java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java: http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java@423 PS16, Line 423: if (typeAttributes == null || !typeAttributes.hasLength() || typeAttributes.getLength() < CharUtil.MIN_VARCHAR_LENGTH Too long (here and elsewhere). http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@45 PS16, Line 45: import static org.apache.kudu.Type.*; Let's omit wildcard imports in production code. http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@647 PS16, Line 647: * @throws IllegalArgumentException if the column doesn't exist, is the wrong type or the string is not UTF-8 This line (and others) is too long; please wrap. http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java: http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@419 PS16, Line 419: * or if the type doesn't match the column's type Nit: in situations like these, could you indent the continuation line so it's clearer that it belongs to the line before it? For example: * @throws IllegalArgumentException if the column is null * or if the type doesn't match the column's type * @throws IndexOutOfBoundsException if the column doesn't exist -- To view, visit http://gerrit.cloudera.org:8080/14050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995 Gerrit-Change-Number: 14050 Gerrit-PatchSet: 16 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2019 19:11:16 +0000 Gerrit-HasComments: Yes
