Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14050 )
Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4 ...................................................................... Patch Set 23: (11 comments) http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java File java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java@41 PS20, Line 41: import org.apache.kudu.util.Pair; > Use the standard java charset here and anywhere else. Done http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@43 PS20, Line 43: /** > Nit: All the other types use `Type.x` where they are used. Remove these and Done http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@659 PS20, Line 659: /** > nit: To match all the addString methods should this call `addStringUtf8`? addString calls addStringUtf8 which calls addVarLengthData, not sure what you mean. http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@403 PS20, Line 403: } > We don't allow VARCHAR on getString in the PartialRow API. We probably shou C++ API specifically doesn't allow implicit casting at this point so GetVarchar() can't be used for STRING columns and vice versa. I think it would be best to match this behavior here as well, so I changed it to disallow using getString() to be used for VARCHAR and vice versa. Is that ok? http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java File java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java@22 PS20, Line 22: import org.junit.Rule; > Nit: put with the kudu imports Done http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java@29 PS20, Line 29: import org.apache.kudu.util.DecimalUtil; > nit: put with the junit imports Done http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java@28 PS20, Line 28: import org.junit.Before; > nit: put with the other kudu imports? Done http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@24 PS20, Line 24: import static org.apache.kudu.test.ClientTestUtil.countRowsInScan; > Nit: Avoid * imports Done http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java@33 PS20, Line 33: import org.junit.Assert; > Nit: put with Kudu imports Done http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java@28 PS20, Line 28: import org.junit.Assert; > Nit: Put with other kudu imports Done http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala: http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala@151 PS20, Line 151: > Is there a test for this? I wonder if Spark will actually create a varchar fair enough, removing it. Does this mean it's not possible to create a VARCHAR columns in Kudu using Spark? -- To view, visit http://gerrit.cloudera.org:8080/14050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995 Gerrit-Change-Number: 14050 Gerrit-PatchSet: 23 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 04 Oct 2019 12:31:34 +0000 Gerrit-HasComments: Yes
